Implemented path recognizer for recognizing along an SVGpath #991
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@arschmitz this is really interesting, at first I thought perhaps this was outside the scope of the core lib, but the more I think about it the more I'd love to see something like this within the lib itself. |
Contributor
|
@runspired i actually totally agree iv been going back and forth with my self over this one but im leaning towards inclusion |
Author
|
@runspired @arschmitz Actually if I had the option I would have written it as a separate module and not as a PR to the hammer core. However after looking at the architecture currently there's no good way to add new recognizers dynamically to hammer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: path recognizer for recognizing along an SVGpath
Implement a recognizer that receives an SVG element and an SVG Path element, and recognizes a user following the path. Recognizer will fail if user starts gesturing at the middle of the path, veers too far from the path or stops input mid-way.
Special parameters:
resolution (default 10) - path will be quantized to this amount of segments
maxDistanceFromSegment (default 30) - the threshold in which input is allowed to stray from the path
Example use case: games where the player needs to follow an onscreen shape to achieve a goal.
Includes a pathRecognizer test in the manual tests dir.